Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable page.spec event handler test for firefox #8214

Merged
merged 1 commit into from Apr 8, 2022
Merged

fix: enable page.spec event handler test for firefox #8214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions test/page.spec.ts
View file
Open in desktop
Expand Up @@ -118,11 +118,7 @@ describe('Page', function () {
});
});

// This test fails on Firefox on CI consistently but cannot be replicated
// locally. Skipping for now to unblock the Mitt release and given FF support
// isn't fully done yet but raising an issue to ask the FF folks to have a
// look at this.
describeFailsFirefox('removing and adding event handlers', () => {
describe('removing and adding event handlers', () => {
it('should correctly fire event handlers as they are added and then removed', async () => {
const { page, server } = getTestState();

Expand Down