Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase commit header length limit #8252

Closed
wants to merge 1 commit into from
Closed

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 20, 2022

04f7659 hit the limit but I don't see a reason why we need to be so strict. Increasing the limit to 120 chars.

@OrKoN OrKoN requested a review from ergunsh April 20, 2022 09:54
@ergunsh
Copy link
Collaborator

ergunsh commented Apr 20, 2022

AFAIU GitHub cuts of the commit to other line when it is longer than 72 characters. So, AFAIU again, that's why the default limit is 72 characters. IMO, it might make sense to keep it in 72 characters to not allow this behavior.

Additional info can be written in other lines, wdyt?

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 20, 2022

The limit already was 100. Also, GitHub cutting off lines is not a big problem as you can see the rest on the next line.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 20, 2022

Alternatively, I can fix that commit with a force push :)

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 20, 2022

Let me just do that, I think.

@OrKoN OrKoN closed this Apr 20, 2022
@OrKoN OrKoN deleted the fix-commitlint branch April 20, 2022 10:10
@ergunsh
Copy link
Collaborator

ergunsh commented Apr 20, 2022

Oh I see, I tried to understand why it was 100 in the first place and it seems like 72 could cause issues with automatic PRs (example conventional-changelog/commitlint#859)

I'm fine with both options now, thank you :)

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 20, 2022

Oh, thanks for digging! yeah, I think 72 is too low for most of typical commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants