Fix NodeNext incompatibility in package.json #8439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec for the "exports" field has it completely take over when present. Latest Typescript (4.7+), when using `moduleResolution` "NodeNext" follows the spec. It therefore looks for types in `package.json/exports/./types`. Puppeteer does not have that value, so Typescript gets confused and throws errors of various sorts on import statements. Adding `package.json/exports/./types = "./lib/types.d.ts"` resolves this.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jrandolf
approved these changes
May 31, 2022
|
@adam-coster Mind signing the CLA so we can submit this? |
|
Merged here: #8445 |
|
@jrandolf Whoops, sorry! Thanks for making the fix anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec for the "exports" field has it completely take over when present. Latest Typescript (4.7+), when using
moduleResolution"NodeNext" follows the spec. It therefore looks for types inpackage.json/exports/./types. Puppeteer does not have that value, so Typescript gets confused and throws errors of various sorts on import statements.Adding
package.json/exports/./types = "./lib/types.d.ts"resolves this.What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No. It's an extremely minor change that should not create backwards incompatibilities and brings the
package.jsonto spec.Summary
Resolves #8438
Does this PR introduce a breaking change?
No.
Other information