New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use CDP's auto-attach mechanism #8520
Merged
Merged
Commits on Jul 21, 2022
-
feat: use CDP's auto-attach mechanism
In this PR, we refactor Puppeteer to make use of CDP's auto-attach mechanism. This allows the backend to pause new targets and give Puppeteer a chance to configure them properly. This fixes the flakiness related to dealing with OOPIFs and should fix a multitude of issues related to the network interception and navigations. If those are not fixed completely by this PR, the PR serves a solid base for fixing them Closes #8507, #7990 Unlocks #3667 BREAKING CHANGE: With Chromium, Puppeteer will now attach to page/iframe targets immediately. BREAKING CHANGE: Browser.connect requires an explicit product name when connecting to Firefox since Firefox does not support CDP's auto-attach.
Configuration menu - View commit details
-
Copy full SHA for e56cd22 - Browse repository at this point
Copy the full SHA e56cd22View commit details -
Configuration menu - View commit details
-
Copy full SHA for d979a74 - Browse repository at this point
Copy the full SHA d979a74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6038cc4 - Browse repository at this point
Copy the full SHA 6038cc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e35754d - Browse repository at this point
Copy the full SHA e35754dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e4a93a - Browse repository at this point
Copy the full SHA 4e4a93aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22a120f - Browse repository at this point
Copy the full SHA 22a120fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ad7324 - Browse repository at this point
Copy the full SHA 3ad7324View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04995e4 - Browse repository at this point
Copy the full SHA 04995e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba9c248 - Browse repository at this point
Copy the full SHA ba9c248View commit details -
Configuration menu - View commit details
-
Copy full SHA for e448453 - Browse repository at this point
Copy the full SHA e448453View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.