chore: enable strict mode in tests #8524

jrandolf · 2022-06-14T23:30:33Z

This PR does a few things:

The testing tsconfig.json inherits from the base TS config.
- A lot of type assertions have been inserted...a lot.
All testing utilities have migrated to TS.
text-diff is being replaced with diff for TS compatibility.
ProtocolError has been added to PuppeteerErrors and PuppeteerErrors is no longer a record (it's been frozen).
Fixes a small bug where null was an allowable media type in emulation (should be undefined).

Issues: #6769

test/src/ariaqueryhandler.spec.ts

jrandolf requested a review from OrKoN June 14, 2022 23:30

jrandolf force-pushed the strict_tests branch 5 times, most recently from 977f530 to 5e8fc99 Compare June 15, 2022 00:14

OrKoN changed the base branch from main to composite1 June 15, 2022 05:21

OrKoN reviewed Jun 15, 2022

View reviewed changes

test/src/ariaqueryhandler.spec.ts Show resolved Hide resolved

OrKoN approved these changes Jun 15, 2022

View reviewed changes

jrandolf force-pushed the composite1 branch from 2d1b23c to 28786c5 Compare June 15, 2022 10:05

Base automatically changed from composite1 to main June 15, 2022 10:05

jrandolf force-pushed the strict_tests branch from 5e8fc99 to 0c0c82a Compare June 15, 2022 10:08

chore: use strict typing in tests

6cd90b7

jrandolf force-pushed the strict_tests branch from 0c0c82a to 6cd90b7 Compare June 15, 2022 10:08

jrandolf merged commit 570087e into main Jun 15, 2022

jrandolf deleted the strict_tests branch June 15, 2022 10:09

Provide feedback