Expose #client via _client() on HTTPRequest
#8545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the puppeteer-page-proxy project a path to working again with the latest versions of puppeteer
This keeps in line with the method call on `Page`
smashah
changed the title
client() on HTTPRequest_client() on HTTPRequest
|
Fixed in #8556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A small change that will allow the puppeteer-page-proxy project a path to working again with the latest versions of puppeteer
Did you add tests for your changes?
_client()is not documented onPageyet still exists so I guess it's not required.Summary
Completely eliminating access to the HTTPRequest._client property will break
puppeteer-page-proxyand in turn negatively affect my users. Forcing my project to use older puppeteer version will also negatively affect my users. I am making this PR so I can eventually make a PR/fork onpuppeteer-page-proxyopen-wa/wa-automate-nodejs#2755
Cuadrix/puppeteer-page-proxy#78
Does this PR introduce a breaking change?
No
Other information