Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deferred promise timeouts #8835

Merged
merged 1 commit into from Aug 24, 2022
Merged

fix: remove deferred promise timeouts #8835

merged 1 commit into from Aug 24, 2022

Commits on Aug 24, 2022

  1. fix: remove deferred promise timeouts

    Issue #8832 makes a good point that we should not be making
    implicit assumptions about the client's performance
    when waiting for internal events. At the same time,
    we want to be able to get the debug info if some promises
    never resolve because of missing backend events.
    
    This PR adds a variable to turn on timeouts for deferred
    promises created using `createDebuggableDeferredPromise`.
    We can use it in our tests to catch never-resolving
    promises or when reproducing bug reports where Puppeteer
    hangs indefinitely.
    
    Closes #8832
    OrKoN committed Aug 24, 2022
    Copy the full SHA
    b0022cf View commit details
    Browse the repository at this point in the history