Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow getting a frame from an elementhandle #8875

Merged
merged 1 commit into from Aug 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/api/puppeteer.elementhandle.frame.md
@@ -0,0 +1,13 @@
---
sidebar_label: ElementHandle.frame
---

# ElementHandle.frame property

**Signature:**

```typescript
class ElementHandle {
get frame(): Frame;
}
```
6 changes: 6 additions & 0 deletions docs/api/puppeteer.elementhandle.md
Expand Up @@ -39,6 +39,12 @@ If you're using TypeScript, ElementHandle takes a generic argument that denotes

The constructor for this class is marked as internal. Third-party code should not call the constructor directly or create subclasses that extend the `ElementHandle` class.

## Properties

| Property | Modifiers | Type | Description |
| ------------------------------------------- | --------------------- | ----------------------------- | ----------- |
| [frame](./puppeteer.elementhandle.frame.md) | <code>readonly</code> | [Frame](./puppeteer.frame.md) | |

## Methods

| Method | Modifiers | Description |
Expand Down
3 changes: 0 additions & 3 deletions src/common/ElementHandle.ts
Expand Up @@ -88,9 +88,6 @@ export class ElementHandle<
return this.#frame.page();
}

/**
* @internal
*/
get frame(): Frame {
return this.#frame;
}
Expand Down