Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: suppress init errors if the target is closed #8947

Merged
merged 1 commit into from Sep 14, 2022
Merged

fix: suppress init errors if the target is closed #8947

merged 1 commit into from Sep 14, 2022

Commits on Sep 14, 2022

  1. fix: supress init errors if the target is closed 

    With #8520 Puppeteer is now aware of all targets it connects
to. In order to have a not flaky init, Puppeteer waits for
all existing targets to be configured during the connection process.
This does not work well in case of concurrent connections because
while one connection might initializing a target the other one
might be closed it. In general, that is expected because we
can only be eventually consistent about the target state but we
also should not crash the init if some targets have been closed.
This PR implements checks to see if the errors are caused by the
target or session closures and supresses them if it's the case.
    @OrKoN
    OrKoN committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    4850a38 View commit details
    Browse the repository at this point in the history