Add new side prop options for Popover component #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new side prop options for the popover component so that its possible to display the arrow in all corners.
sean-mckenna
force-pushed
the
add-side-to-popover
branch
from
dceaba3
to
8944701
Compare
mttsltrs
approved these changes
Apr 3, 2024
mttsltrs
reviewed
Apr 3, 2024
| @@ -12,7 +12,16 @@ const propTypes = { | |||
| /** Component children */ | |||
| children: PropTypes.node, | |||
| /** Side the arrow appears on */ | |||
| side: PropTypes.oneOf(['top', 'bottom', 'left', 'right']), | |||
| side: PropTypes.oneOf([ | |||
There was a problem hiding this comment.
would it be worth going with top-left, top-right etc just to be more explicit?
There was a problem hiding this comment.
I had thought about it, but that would be a breaking change and would require a major version bump. We could target that kind of change in v6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add new side prop options for the popover component so that its possible to display the arrow in all corners.
Screenshot of proposed changes