(CDPE-6706) Fix logo text SVG being cut off on sidebar #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergmurphy
force-pushed
the
CDPE-6706/fix_logo_svg_on_sidebar
branch
from
78390e3
to
61f09de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Increase continuous delivery logo viewBox size to fix issue with logo text being cut off when the
expandedprop is set to true on the logo component. The problem occurs in the Sidebar component when it adds theexpandedprop to the Logo, this is the only instance of theexpandedprop should be used on the Logo.Screenshot of proposed changes
Old:
New: