Ignore package-lock.json files #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. I fall on the "we should commit package-lock for packages" side of that stack overflow thread, but of course we need lerna support. Let's follow that issue thread and update if / when it gets resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nmuldavin, I noticed that you un-ignored package-lock.json files in 4cb1363#diff-a084b794bc0759e7a6b77810e01874f2L3. I'm re-ignoring package-lock.json files for the time being due to Lerna not bumping package versions in package-lock.json, though there is a Lerna issue (lerna/lerna#1998) to address that.
There isn't total agreement on whether or not to commit package-lock.json for packages. In my most popular Stack Overflow answer (https://stackoverflow.com/a/44210813/2321452) 馃槅 I mentioned that Sindre Sorhus recommends using "Lockfiles for apps, but not for packages" but James Kyle recommends committing lockfiles for libraries/packages to make contributing easier. Either way, package-lock.json is not published so doesn't affect consumers. That Lerna issue is making diffs show up when there aren't real changes, which makes contributing more annoying, so I'm suggesting following Sindre's advice and ignoring package-lock.json files in design-system packages for now.