(PE-36370) remove yaml support #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes support for yaml configuration files from trapperkeeper. The yaml configuration is not a common case, and not used in Puppet Enterprise at all. The yaml parser is the source of multiple CVEs.
This adds PR based testing and kondo and eastwood linting via github actions.
This resolves the clj-kondo linting warnings found when clj-kondo was enabled.
jonathannewman
force-pushed
the
PE-36370/main/remove-yaml-support
branch
from
6ef7eba
to
512a819
Compare
This fixes and ignores issues found by eastwood.
jonathannewman
force-pushed
the
PE-36370/main/remove-yaml-support
branch
from
aed7f77
to
bb828ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for yaml configuration files from trapperkeeper.
The yaml configuration is not a common case, and not used in Puppet
Enterprise at all. The yaml parser is the source of multiple CVEs.