Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate lib from executable #56

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

matthewleon
Copy link
Contributor

@matthewleon matthewleon commented Aug 10, 2017

addresses #53

This is a work in progress, but the general direction should be reasonably clear at this point. Some notes for things that need to get done:

  • Move things out of Main
  • Adopt a Monad allowing library users to silence echo.
  • Documentation

@matthewleon
Copy link
Contributor Author

@paf31 This is now ready for review. I'd never added anything to Hackage before, and thought it might require some changes... But it looks like it doesn't.

@paf31
Copy link
Contributor

paf31 commented Aug 17, 2017

I'm going to get to this soon, but it's a pretty big PR so I have to find time. I don't understand your comment about Hackage though.

@matthewleon
Copy link
Contributor Author

I don't understand your comment about Hackage though.

Oh, just that I initially thought that I would need to write some kind of script or metadata file to support uploading to Hackage, but that it appears as though that's unnecessary.

Rembane pushed a commit to Rembane/psc-package that referenced this pull request May 26, 2018
@JordanMartinez
Copy link

Should we close this PR? I haven't read through this PR's content and what it's trying to change. However, psc-package is generally no longer used by the community as most use spago now, though there may be some who still use it.

@paf31
Copy link
Contributor

paf31 commented Sep 20, 2021

If it's not being maintained, why not archive the repo entirely instead?

@JordanMartinez
Copy link

I'm up for archiving this repo. @justinwoo, what are your thoughts? IIRC, you were using this previously.

@justinwoo
Copy link
Collaborator

i don't understand your thought process for asking me that question.

@JordanMartinez
Copy link

Ah, let me clarify. I don't think anyone is actually using this tool anymore, but I do remember that you used it in the past. I wasn't sure if you were still using it and thus if archiving this would impact your usage of the tool. So, I thought I would ask.

@justinwoo
Copy link
Collaborator

yes, i am still using this tool

@JordanMartinez
Copy link

Thanks for clarifying, Justin.

It looks like there was some previous agreement about transferring this repo out of the purescript GitHub organization into the purescript-contrib organization (see #156 (comment) and the following comment). However, that transfer never took place.

As a member of the purescript-contrib organiztion, I don't personally want to maintain this library. While I can't speak for the other members, I would guess that they don't want to either. So, continuing with the decision previously made to transfer this repo there doesn't sound good.

Assuming other purescript-contrib members don't want to maintain this, we can either archive this project or transfer it to someone else. @justinwoo, in #156 (comment), it sounded like transferring this repo to you didn't seem appropriate to you. Correct me if I'm wrong, but I'm guessing that's still your thought process.

Unless someone else wants to maintain this project (whether a core team member, a purescript-contrib member, or just anyone in the PureScript community as a whole), then the only option left is to archive this project.

If I don't hear comments from anyone else on the matter, I'll archive this project in two weeks (i.e. Oct 11).

@justinwoo
Copy link
Collaborator

i don't understand why you keep commenting in this PR thread, but okay.

does this project need anyone to maintain it other than me? does someone need to actively shuffle things around in this project? is there some need to have someone other than me to do anything in this project?

also consider that references to this project will break if you move it. you can archive this project, but if you delete it, you will end up breaking anything using those references.

what are you hoping will come out of this discussion?

@justinwoo
Copy link
Collaborator

please also understand that i no longer believe things i said in the comments in #156. i am not infallible and have realized i want to continue using psc-package, and use it regularly as a result.

@JordanMartinez
Copy link

i don't understand why you keep commenting in this PR thread, but okay.

I actually almost opened an issue to further discuss this 😄 I don't want to spam this PR's author with notifications, but it also felt like it might be weird to stop the conversation partway.

Let's just open a new issue for this discussion. I'll respond to your questions and comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants