Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'patch' verb to nodes resource in clusterrole to allow for node draining #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

metacyclic
Copy link

When draining a node from k8s, the first step is to patch the node spec and set node.Spec.Unschedulable=true. The current cluster role example doesn't include it, and it throws errors like shown in #7. Adding this verb does indeed fix the issue.

@pusher-ci
Copy link

Hi @metacyclic. Thanks for your PR.

I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants