Add feature to deprecate config options and refactor pwndbg.color.context #1339
Conversation
| from pwndbg.gdblib import config | ||
|
|
||
| config_prefix_color = theme.add_color_param( | ||
| "code-prefix-color", "none", "color for 'context code' command (prefix marker)" | ||
| # TODO: Should probably change - to . |
There was a problem hiding this comment.
Before making this change we should decide on exactly how we want the namespacing to look. Should a config option appear as context-code-prefix-color, context.code-prefix-color, or context.code.prefix-color? I prefer the last option, but I'm also OK with the second option.
An alternative here is I can disable the warning (while keeping the forwarding to the new parameters), and then we can just figure out how we want to do this later.
There was a problem hiding this comment.
@disconnect3d Ping on this question.
There was a problem hiding this comment.
Another option is: context code prefix-color but I think keeping it without spaces may make more sense.
Anyway, context.code.prefix-color or context-code-prefix-color i think
gsingh93
force-pushed
the
context-color
branch
from
38e3a51
to
6ca1c9d
Compare
gsingh93
force-pushed
the
context-color
branch
from
6ca1c9d
to
1e2dea3
Compare
The changes to lib/config.py and gdblib/config.py add a way to deprecate configuration parameters. When a configuration parameter is deprecated, the first time a user tries to set it, they'll see a warning telling them the new parameter name. Any time a user tries to set a deprecated parameter, we forward it to the new parameter.
This PR also refactors pwndbg.color.context to use
ColorConfig, and makes use of the configuration deprecation.