Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support large pull requests #508

Closed

Conversation

robsonpeixoto
Copy link

Does this pull request fix one issue?

Fixes #302

Describe how you did it

Instead of use the gh paginator, this module will paginate to the all files from a PR to avoid json_decode problem.

Describe how to verify it

Start/Resume a large pull-request

@pwntester
Copy link
Owner

Thanks! It would be nice if you could extract the pagination logic to the utils module so it could be reused by other methods in the future.

The pagination method could take the base URL, a table to hold aggregated responses and an aggregator function, eg: utils.aggregate(base_url, files, aggregator)

@pwntester pwntester marked this pull request as draft March 17, 2024 20:21
@robsonpeixoto
Copy link
Author

Sorry, I'm without time to continue this PR.

@robsonpeixoto robsonpeixoto deleted the fix/support-large-pr branch April 22, 2024 16:41
@Afourcat
Copy link

Hello,
Is there any reason, other than the OP being unable to continue, that led to the closing of this PR?
This would be really helpful, as I'm currently unable to use Octo in my workflow.
I may be able to allocate the time to finish the work of the OP in the following weeks, if necessary.

@robsonpeixoto
Copy link
Author

This PR is not a elegant solution, @Afourcat. If you would like, feel free to open a new PR with the same content. Or even better, to follow the @pwntester suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octo review start fails with large pull requests
3 participants