Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug causing a warning message in Acrobat #1145

Merged
merged 2 commits into from Apr 12, 2024

Conversation

GerardoAllende
Copy link

Fixes #960 #1144

Checklist:

  • The GitHub pipeline is OK (green)

  • A unit test is covering the code added / modified by this PR
    Not necessary in this case IMHO

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@andersonhc
Copy link
Collaborator

There are 2 tests failing:
2024-04-11T21:43:38.8306068Z test/image/image_types/test_insert_images.py::test_insert_jpg_jpxdecode FAILED [ 37%]
2024-04-11T21:43:39.9141525Z test/image/png_indexed/test_png_indexed.py::test_png_indexed_no_transparency FAILED [

@GerardoAllende
Copy link
Author

Strange, they are not failing on my machine...
image
I'll investigate

@GerardoAllende GerardoAllende changed the title fix bug causing a warning message in Acrobat (#960) (#1144) fix bug causing a warning message in Acrobat Apr 11, 2024
Copy link
Collaborator

@gmischler gmischler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool piece of investigation, figuring this out. Thanks!

@gmischler
Copy link
Collaborator

gmischler commented Apr 12, 2024

There are 2 tests failing:

Where do you see that?
Edit: Oh, now I see the two changed files.

@andersonhc
Copy link
Collaborator

@allcontributors
please add @GerardoAllende for bug.
please add @GerardoAllende for research.

Copy link

@andersonhc

I've put up a pull request to add @GerardoAllende! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acrobat: An error exists on this page. (with multiple SVG imports)
3 participants