Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new optional parameter repeat_headings for FPDF.table() #1153

Merged
merged 2 commits into from May 3, 2024

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented May 2, 2024

Requested in #1151

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@Lucas-C
Copy link
Member Author

Lucas-C commented May 2, 2024

Note: the pipeline is failing for now because CodeCov is KO: https://status.codecov.com/

fpdf/fpdf.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (a313586) to head (b519614).
Report is 6 commits behind head on master.

❗ Current head b519614 differs from pull request most recent head 96dbf9b. Consider uploading reports for the commit 96dbf9b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   93.27%   93.26%   -0.01%     
==========================================
  Files          30       30              
  Lines        9228     9246      +18     
  Branches     2103     2104       +1     
==========================================
+ Hits         8607     8623      +16     
- Misses        379      383       +4     
+ Partials      242      240       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lucas-C
Copy link
Member Author

Lucas-C commented May 3, 2024

I switched to using an enum value.

@Lucas-C Lucas-C merged commit d7d0ab2 into master May 3, 2024
13 checks passed
@Lucas-C Lucas-C deleted the allow-not-not-repeat-headings branch May 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants