Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for functional connectivity #202

Merged
merged 30 commits into from
Dec 21, 2022
Merged

Conversation

mccorsi
Copy link
Contributor

@mccorsi mccorsi commented Sep 29, 2022

Hello,

With Sylvain Chevallier, we worked on an example that uses coherence function from pyriemann to build an ensemble classifier and compares the results with those from the state-of-the-art methods.

This approach is based on the one proposed in:
Corsi, M.-C., Chevallier, S., De Vico Fallani, F. & Yger, F. (2022). Functional connectivity ensemble method to enhance BCI performance (FUCONE). IEEE TBME. http://doi:10.1109/TBME.2022.3154885

This example reuses data from the EEGBCI dataset already used in the documentation.

Best,
Marie-Constance Corsi.

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share the rendered doc page when you have it?

examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/plot_ensemble_coherence.py Outdated Show resolved Hide resolved
examples/motor-imagery/plot_ensemble_coherence.py Outdated Show resolved Hide resolved
examples/motor-imagery/plot_ensemble_coherence.py Outdated Show resolved Hide resolved
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution!

examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/coherence_helpers.py Outdated Show resolved Hide resolved
examples/motor-imagery/plot_ensemble_coherence.py Outdated Show resolved Hide resolved
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for this contribution, and to improve test base.
Do not forget to complete whatsnew.

examples/motor-imagery/plot_ensemble_coherence.py Outdated Show resolved Hide resolved
examples/motor-imagery/plot_ensemble_coherence.py Outdated Show resolved Hide resolved
pyriemann/utils/base.py Outdated Show resolved Hide resolved
pyriemann/utils/base.py Outdated Show resolved Hide resolved
pyriemann/utils/test.py Outdated Show resolved Hide resolved
examples/motor-imagery/helpers/coherence_helpers.py Outdated Show resolved Hide resolved
pyriemann/utils/base.py Outdated Show resolved Hide resolved
examples/motor-imagery/helpers/coherence_helpers.py Outdated Show resolved Hide resolved
pyriemann/utils/test.py Outdated Show resolved Hide resolved
pyriemann/utils/test.py Outdated Show resolved Hide resolved
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
sylvchev and others added 3 commits December 13, 2022 22:50
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
doc/whatsnew.rst Outdated Show resolved Hide resolved
sylvchev and others added 3 commits December 19, 2022 18:23
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @mccorsi and @sylvchev !

@qbarthelemy
Copy link
Member

However, documentation build is KO.

@sylvchev
Copy link
Member

However, documentation build is KO.

Yes, examples/signal/plot_covariance_estimation.py seems to have trouble to generate filled error bar.

@qbarthelemy
Copy link
Member

@qbarthelemy
Copy link
Member

Doc build is OK.
Solution found here mwaskom/seaborn#3194

@sylvchev
Copy link
Member

Thanks @qbarthelemy , I checked the doc and all is ok. Ready to merge!

@qbarthelemy qbarthelemy merged commit 84c78c4 into pyRiemann:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants