rebuild if the OPENSSL_DIR has changed #10290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Jan 29, 2024
| @@ -25,6 +25,9 @@ fn main() { | |||
| let out_dir = env::var("OUT_DIR").unwrap(); | |||
| // FIXME: maybe pyo3-build-config should provide a way to do this? | |||
| let python = env::var("PYO3_PYTHON").unwrap_or_else(|_| "python3".to_string()); | |||
| if let Ok(dir) = env::var("OPENSSL_DIR") { | |||
There was a problem hiding this comment.
This should probably just be in rust-openssl right? Is there a reason it shouldn't?
There was a problem hiding this comment.
Nope! Up there would make the most sense, especially since it finds OPENSSL_DIR if the env isn't set anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably needs to be done in other crates too? And what if
OPENSSL_DIRisn't set?