use hashbrown to speedup python string caching #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
commented
Nov 30, 2023
| RawEntryMut::Occupied(view) => (view.get().clone_ref(py).attach_into(py), false), | ||
| }; | ||
| if inserted { | ||
| // 500k limit means 1m keys + values, 1m 64 byte strings is ~64mb |
There was a problem hiding this comment.
better I think do only do this if we inserted a key rather than always, even if that means clearing the key we just inserted.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dh/py2 #43 +/- ##
==========================================
- Coverage 89.53% 89.46% -0.08%
==========================================
Files 9 9
Lines 1061 1063 +2
==========================================
+ Hits 950 951 +1
- Misses 111 112 +1
Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #43 will not alter performanceComparing Summary
Benchmarks breakdown
|
|
Superseded by #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets the
dh/py2branch to avoid future conflicts.