Skip to content

Commit

Permalink
Reflect namedtuple default values during validation (#7144)
Browse files Browse the repository at this point in the history
  • Loading branch information
dmontagu committed Aug 16, 2023
1 parent 2d9421c commit 37b7f08
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pydantic/_internal/_generate_schema.py
Expand Up @@ -1130,7 +1130,9 @@ def _namedtuple_schema(self, namedtuple_cls: Any, origin: Any) -> core_schema.Co

arguments_schema = core_schema.arguments_schema(
[
self._generate_parameter_schema(field_name, annotation)
self._generate_parameter_schema(
field_name, annotation, default=namedtuple_cls._field_defaults.get(field_name, Parameter.empty)
)
for field_name, annotation in annotations.items()
],
metadata=build_metadata_dict(js_prefer_positional_arguments=True),
Expand Down
9 changes: 9 additions & 0 deletions tests/test_types_namedtuple.py
Expand Up @@ -199,3 +199,12 @@ class MyNamedTuple(TypingExtensionsNamedTuple, Generic[T]):
'type': 'int_parsing',
}
]


def test_namedtuple_defaults():
class NT(NamedTuple):
x: int
y: int = 33

assert TypeAdapter(NT).validate_python([1]) == (1, 33)
assert TypeAdapter(NT).validate_python({'x': 22}) == (22, 33)

0 comments on commit 37b7f08

Please sign in to comment.