Improve error message for NameEmail (#6939)

pydantic · Aug 16, 2023 · 7908718 · 7908718
1 parent f4e96d8
commit 7908718
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/pydantic/networks.py b/pydantic/networks.py
@@ -247,7 +247,11 @@ def __get_pydantic_core_schema__(
         import_email_validator()
         return core_schema.general_after_validator_function(
             cls._validate,
-            core_schema.union_schema([core_schema.is_instance_schema(cls), core_schema.str_schema()]),
+            core_schema.union_schema(
+                [core_schema.is_instance_schema(cls), core_schema.str_schema()],
+                custom_error_type='name_email_type',
+                custom_error_message='Input is not a valid NameEmail',
+            ),
             serialization=core_schema.to_string_ser_schema(),
         )
 

diff --git a/tests/test_networks.py b/tests/test_networks.py
@@ -834,3 +834,9 @@ class Model(BaseModel):
     assert str(Model(v='foo bar  <foobaR@example.com>').v) == 'foo bar <foobaR@example.com>'
     assert NameEmail('foo bar', 'foobaR@example.com') == NameEmail('foo bar', 'foobaR@example.com')
     assert NameEmail('foo bar', 'foobaR@example.com') != NameEmail('foo bar', 'different@example.com')
+
+    with pytest.raises(ValidationError) as exc_info:
+        Model(v=1)
+    assert exc_info.value.errors() == [
+        {'input': 1, 'loc': ('v',), 'msg': 'Input is not a valid NameEmail', 'type': 'name_email_type'}
+    ]