Improve warning message when a field name shadows a field in a parent…

… model (#9105)
pydantic · Mar 26, 2024 · e3b4633 · e3b4633
1 parent af3d335
commit e3b4633
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pydantic/_internal/_fields.py b/pydantic/_internal/_fields.py
@@ -193,7 +193,8 @@ def collect_model_fields(  # noqa: C901
                     # on the class instance.
                     continue
                 warnings.warn(
-                    f'Field name "{ann_name}" shadows an attribute in parent "{base.__qualname__}"; ',
+                    f'Field name "{ann_name}" in "{cls.__qualname__}" shadows an attribute in parent '
+                    f'"{base.__qualname__}"',
                     UserWarning,
                 )
 

diff --git a/tests/test_main.py b/tests/test_main.py
@@ -3131,12 +3131,12 @@ def __pydantic_init_subclass__(cls, **kwargs: Any):
     class One(Model):
         foo: str = 'abc'
 
-    with pytest.warns(UserWarning, match=r'"foo" shadows an attribute in parent ".*One"'):
+    with pytest.warns(UserWarning, match=r'"foo" in ".*Two" shadows an attribute in parent ".*One"'):
 
         class Two(One):
             foo: str
 
-    with pytest.warns(UserWarning, match=r'"foo" shadows an attribute in parent ".*One"'):
+    with pytest.warns(UserWarning, match=r'"foo" in ".*Three" shadows an attribute in parent ".*One"'):
 
         class Three(One):
             foo: str = 'xyz'