Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ForwardRef wrapper for py 3.10.0 (shim until bpo-45166) #6919

Merged

Conversation

randomir
Copy link
Contributor

@randomir randomir commented Jul 27, 2023

Fixes #6912.

Change Summary

Extend a fix described here for Python 3.9 branch to Python 3.10 branch. 3.10.1 is the first version in the 3.10 branch to include the get_type_hints fix bpo-45166.

Related issue number

Fixes #6912.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@randomir
Copy link
Contributor Author

Verified this fixes #6912 in 3.10.0. Please review.

@adriangb adriangb merged commit 6a0038b into pydantic:main Jul 27, 2023
48 checks passed
@randomir randomir deleted the bugfix/fix-type-hints-for-py310/issue-6912 branch July 27, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from pydantic import RootModel fails in Python 3.10.0
2 participants