Make the v1 mypy plugin work with both v1 and v2 #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
32ea931
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b12bf45.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://v1-mypy-plugin-v2.pydantic-docs2.pages.dev |
dmontagu
changed the title
1 task
|
please review |
|
Do we need this PR for |
|
I just figured this would make it faster/easier to deploy, and ensure it got into the next release even if we didn't do a release of v1. I'm okay either way, the main thing is that, in principle, this change should only affect v1-included-into-v2, so it seems less important to me that we get a release of v1 out at the same time. That's in contrast with actual bugfixes to v1. |
hramezani
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6898
See #6920 for the corresponding PR to the
1.10.X-fixesbranch.Selected Reviewer: @samuelcolvin