Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MultiHostUrl type instead of Union for MongoDsn #6949

Closed
wants to merge 1 commit into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jul 30, 2023

No description provided.

@Kludex Kludex marked this pull request as draft July 30, 2023 07:32
CockroachDsn.build(scheme='cockroachdb', username='user', password='password', host='localhost', port=5432)
AmqpDsn.build(scheme='amqp', username='user', password='password', host='localhost', port=5672, path='/db')
RedisDsn.build(scheme='redis', username='user', password='password', host='localhost', port=6379, path='/db')
# MongoDsn.build(scheme='mongodb', username='user', password='password', host='localhost', port=27017, path='/db')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work because MongoDsn is a Union.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d3b2e7
Status: ✅  Deploy successful!
Preview URL: https://e0f35d64.pydantic-docs2.pages.dev
Branch Preview URL: https://mongodbdsn-failing.pydantic-docs2.pages.dev

View logs

@Kludex Kludex marked this pull request as ready for review August 17, 2023 03:57
@Kludex
Copy link
Member Author

Kludex commented Aug 23, 2023

@Kludex Kludex closed this Aug 23, 2023
@Kludex Kludex deleted the mongodbdsn-failing branch August 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant