Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dataclass annotated before validator called twice #6998

Merged
merged 1 commit into from Aug 2, 2023
Merged

fix dataclass annotated before validator called twice #6998

merged 1 commit into from Aug 2, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Removes some duplication of collecting annotations for data class fields.

Related issue number

Fixes #6962

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt mentioned this pull request Aug 2, 2023
Closed
@davidhewitt davidhewitt enabled auto-merge (squash) August 2, 2023 19:34
@davidhewitt davidhewitt merged commit adc657a into main Aug 2, 2023
48 checks passed
@davidhewitt davidhewitt deleted the dh/before-validator-once branch August 2, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BeforeValidator runs twice in case when dataclass
2 participants
@davidhewitt @adriangb