New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: mypy error with Settings
and SettingsConfigDict
#7002
Fix: mypy error with Settings
and SettingsConfigDict
#7002
Conversation
please review |
6666168
to
e2cb3dd
Compare
Thanks @JeanArhancet for the fix 🙏 This LGTM 👍 test fast-api is failing that will be fixed after #7014 @dmontagu it would be great if you also take a look |
I filed what is believed to be a version of this issue at python/mypy#15804, and after installing this branch it seems to fix the error. 👍 |
@JeanArhancet please rebase on top of main. |
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
230bf31
to
6ff8ec4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick chat with @dmontagu about this offline, LGTM. Many thanks 👍
Change Summary
Fix mypy error with
Settings
andSettingsConfigDict
Related issue number
Fix #6985
Checklist
Selected Reviewer: @davidhewitt