Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with JSON schema incorrectly using parent class core schema #7020

Merged
merged 2 commits into from Aug 16, 2023
Merged

Fix issue with JSON schema incorrectly using parent class core schema #7020

merged 2 commits into from Aug 16, 2023

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Aug 7, 2023 •
edited by pydantic-hooky bot

Closes #7004

Selected Reviewer: @hramezani

@dmontagu dmontagu mentioned this pull request Aug 7, 2023
Closed
1 task
@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 7, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 662e9ea
Status: ✅  Deploy successful!
Preview URL: https://5d30e95c.pydantic-docs2.pages.dev
Branch Preview URL: https://rebuild-for-json-schema.pydantic-docs2.pages.dev

View logs

@dmontagu
Copy link
Contributor Author

please review

@dmontagu dmontagu merged commit e1bc4e1 into main Aug 16, 2023
49 checks passed
@dmontagu dmontagu deleted the rebuild-for-json-schema branch August 16, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@hramezani hramezani

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

model_json_schema() not creating JSON schema when subclassed
2 participants
@dmontagu @hramezani