Fix config.defer_build for serialization first cases
#7024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1977786
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c62fc1e7.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://defer-build-on-serialization.pydantic-docs2.pages.dev |
|
just the fastapi tests failing. Please review. |
|
@MarkusSintonen if you do have a chance to look at this, another cprofile output like you added to #6768 would be really useful 🙏. |
samuelcolvin
force-pushed
the
defer_build-on-serialization
branch
from
7c71e73
to
51725f5
Compare
|
@samuelcolvin testing with this branch still gives some strange failures when enabling def test_partial_creation_with_defer_build():
BaseModel.model_config["defer_build"] = True # Actually setup close to the (tests) entrypoint. Feels a bit hacky.
class M(BaseModel):
a: int
b: int
def create_partial(model: type[BaseModel], optionals: set[str]) -> type[BaseModel]:
override_fields: dict[str, tuple[Any, FieldInfo]] = {}
for name, field in model.model_fields.items():
if field.is_required() and name in optionals:
assert field.annotation is not None
override_fields[name] = ((field.annotation | None), FieldInfo.merge_field_infos(field, default=None))
return create_model(f"Partial{model.__name__}", __base__=model, **cast(dict, override_fields))
partial = create_partial(M, {"a"})
# Comment this away and the last assertion works
assert M.model_json_schema()["required"] == ["a", "b"]
# AssertionError: assert ['a', 'b'] == ['b']
assert partial.model_json_schema()["required"] == ["b"] |
|
With 2.1.1 without |
|
This is really useful, thank you.
Hoped, but not expected. 🤷 We have some big plans in the works to remove some calls to walk, in the meantime we'll continue to look for smaller improvements. |
|
Needs to be refreshed |
samuelcolvin
force-pushed
the
defer_build-on-serialization
branch
from
bce37cf
to
9e0f4f2
Compare
Thanks so much @MarkusSintonen I've added your tests to our unit tests, unfortunately since In summary, you'll need to call |
samuelcolvin
force-pushed
the
defer_build-on-serialization
branch
from
e7dd2da
to
c1f947e
Compare
|
please review. |
samuelcolvin
force-pushed
the
defer_build-on-serialization
branch
from
c1f947e
to
1977786
Compare
adriangb
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
@MarkusSintonen might be a good idea if you try this as a PR, rather than waiting a release to find my dumb bugs 🙃 ?
Related issue number
continues from #6823 as per comment from @MarkusSintonen #6768 (comment)
Checklist
Selected Reviewer: @dmontagu