tweaks to _core_utils
#7040
Merged
tweaks to _core_utils
#7040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review. |
davidhewitt
approved these changes
Aug 14, 2023
pydantic/_internal/_core_utils.py
Outdated
| replaced_fields: dict[str, core_schema.ModelField] = {} | ||
| replaced_computed_fields: list[core_schema.ComputedField] = [] | ||
| for computed_field in schema.get('computed_fields', None) or (): | ||
| for computed_field in schema.get('computed_fields') or (): |
There was a problem hiding this comment.
Suggested change
| for computed_field in schema.get('computed_fields') or (): | |
| for computed_field in schema.get('computed_fields', ()): |
pydantic/_internal/_core_utils.py
Outdated
| replaced_computed_fields: list[core_schema.ComputedField] = [] | ||
| for computed_field in schema.get('computed_fields', None) or (): | ||
| for computed_field in schema.get('computed_fields') or (): |
There was a problem hiding this comment.
Suggested change
| for computed_field in schema.get('computed_fields') or (): | |
| for computed_field in schema.get('computed_fields', ()): |
pydantic/_internal/_core_utils.py
Outdated
| @@ -345,7 +348,7 @@ def handle_typed_dict_schema(self, schema: core_schema.TypedDictSchema, f: Walk) | |||
| def handle_dataclass_args_schema(self, schema: core_schema.DataclassArgsSchema, f: Walk) -> core_schema.CoreSchema: | |||
| replaced_fields: list[core_schema.DataclassField] = [] | |||
| replaced_computed_fields: list[core_schema.ComputedField] = [] | |||
| for computed_field in schema.get('computed_fields', None) or (): | |||
| for computed_field in schema.get('computed_fields') or (): | |||
There was a problem hiding this comment.
Suggested change
| for computed_field in schema.get('computed_fields') or (): | |
| for computed_field in schema.get('computed_fields', ()): |
Deploying with
|
| Latest commit: |
5525777
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7df1e640.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://tweak-fastapi-startup-test.pydantic-docs2.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
some trivial cleanup to
_core_utils::Walk.Related issue number
related to #6768
Checklist
Selected Reviewer: @hramezani