Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring of ser_json_bytes regarding base64 encoding #7052

Merged
merged 1 commit into from Aug 9, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Aug 9, 2023

Change Summary

Related to #7000

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@Viicos
Copy link
Contributor Author

Viicos commented Aug 9, 2023

Please review

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@samuelcolvin samuelcolvin merged commit 35fc879 into pydantic:main Aug 9, 2023
48 checks passed
@Viicos Viicos deleted the Viicos-patch-1 branch August 9, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants