Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace almost_equal_floats with math.isclose #7082

Merged
merged 1 commit into from Aug 10, 2023
Merged

Replace almost_equal_floats with math.isclose #7082

merged 1 commit into from Aug 10, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Aug 10, 2023 •
edited by pydantic-hooky bot

Change Summary

Replace the own method almost_equal_floats with stdlib's math.isclose.

No need to add to changelog.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@eumiro eumiro marked this pull request as ready for review August 10, 2023 19:26
@eumiro
Copy link
Contributor Author

eumiro commented Aug 10, 2023

please review

@davidhewitt
Copy link
Contributor

Thanks for the PR! I'm in favour of removing this from V2 as it's a private internal but I think we should leave the pydantic.v1 namespace untouched.

davidhewitt
davidhewitt requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update (remove changes from pydantic.v1)

@pydantic-hooky pydantic-hooky bot assigned eumiro and unassigned davidhewitt Aug 10, 2023
@eumiro
Copy link
Contributor Author

eumiro commented Aug 10, 2023

@davidhewitt thanks for the feedback. I have reverted changes in V1.

@davidhewitt davidhewitt enabled auto-merge (squash) August 10, 2023 20:34
@davidhewitt davidhewitt merged commit 84a8014 into pydantic:main Aug 10, 2023
47 checks passed
@eumiro eumiro deleted the almost_equal branch August 10, 2023 20:41
@eumiro eumiro mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

@eumiro eumiro

Labels
awaiting author revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eumiro @davidhewitt