New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require validate_assignment
to use Field.frozen
#7103
Do not require validate_assignment
to use Field.frozen
#7103
Conversation
It is intended behavior. The second example will work if Probably we can improve the the docstring and documentation here |
Then should the first example I gave follows the same idea (requiring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for the contribution.
Change Summary
I find it a bit unusual to have the following working:
But not the following:
If you think the current behavior is as designed, I can revert my commit but I think a note on the
Field.frozen
docstring would be required.Checklist
Selected Reviewer: @samuelcolvin