Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy 1.5.0 #7118

Merged
merged 1 commit into from Aug 16, 2023
Merged

Add mypy 1.5.0 #7118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -180,7 +180,7 @@ jobs:
matrix:
# test recent mypy versions on 3.10 and mypy 1.0.1 on all supported python versions
# if you change the value in the lockfile add the old value to this list
mypy-version: ['1.0.1', 'lockfile', '1.2.0', '1.4.1']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point we should start removing these

mypy-version: ['1.0.1', 'lockfile', '1.2.0', '1.4.1', '1.5.0']
python-version: ['3.10']
include:
- mypy-version: 'lockfile'
Expand Down Expand Up @@ -208,6 +208,10 @@ jobs:
- name: install mypy
if: steps.cache.outputs.cache-hit != 'true'
run: |
if [ ${{ matrix.mypy-version }} == '1.5.0' ]; then
# mypy 1.5.0 only supports 3.8 and newer, so adjust pyproject.toml
sed -i "s/requires-python = '>=3.7'/requires-python = '>=3.8'/g" pyproject.toml
fi
if [ ${{ matrix.mypy-version }} != 'lockfile' ]; then
pdm remove -G linting mypy && pdm remove -G mypy mypy && pdm add mypy==${{ matrix.mypy-version }}
fi
Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Expand Up @@ -55,6 +55,7 @@ test-mypy-update-all: .pdm
pip install --force mypy==1.1.1 && make test-mypy-update
pip install --force mypy==1.2.0 && make test-mypy-update
pip install --force mypy==1.4.1 && make test-mypy-update
pip install --force mypy==1.5.0 && make test-mypy-update

.PHONY: test-pyright ## Run the pyright integration tests
test-pyright: .pdm
Expand Down