Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an error message hint for inherited ordering #7124

Merged

Conversation

yohanvalencia
Copy link
Contributor

@yohanvalencia yohanvalencia commented Aug 15, 2023

Change Summary

Introducing a subtle error message hint.

Related issue number

fix #7006

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@hramezani
Copy link
Member

Thanks @yvalencia91 for this patch 🙏

Please add a test for this change. You can check test_generic_subclass_with_extra_type_requires_all_params to get an idea about how to test it.

Also, Let's see whether @dmontagu is happy about the hint.

Please update

@yohanvalencia
Copy link
Contributor Author

Thanks @yvalencia91 for this patch 🙏

Please add a test for this change. You can check test_generic_subclass_with_extra_type_requires_all_params to get an idea about how to test it.

Also, Let's see whether @dmontagu is happy about the hint.

Please update

@hramezani thanks for the hint!

tests/test_generics.py Outdated Show resolved Hide resolved
tests/test_generics.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

please review

@dmontagu dmontagu merged commit 8ed6ea4 into pydantic:main Aug 16, 2023
49 checks passed
@dmontagu
Copy link
Contributor

Thanks for the contribution! I just tweaked the error message a bit, hopefully that's all right.

@yohanvalencia yohanvalencia deleted the add-hint-comment-when-inheriting branch August 16, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow partial parametrization of Generic classes
4 participants