Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ser_json_<timedelta|bytes> on default in GenerateJsonSchema #7269

Merged
merged 6 commits into from Aug 29, 2023

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Aug 28, 2023

Change Summary

Support ser_json_timedelta and ser_json_bytes on default_schema.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Kludex Kludex changed the title Support ser_json_timedelta and ser_json_bytes on default in GenerateJsonSchema Use ser_json_<timedelta|bytes> on default in GenerateJsonSchema Aug 28, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8338739
Status: ✅  Deploy successful!
Preview URL: https://e1dfab3d.pydantic-docs2.pages.dev
Branch Preview URL: https://feat-support-ser-json-timede.pydantic-docs2.pages.dev

View logs

Comment on lines 303 to 305
@property
def config(self) -> _config.ConfigWrapper:
return self._config_wrapper_stack.tail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to make this public?

@Kludex Kludex marked this pull request as ready for review August 29, 2023 13:41
@dmontagu dmontagu merged commit 2acf1af into main Aug 29, 2023
50 checks passed
@dmontagu dmontagu deleted the feat/support-ser-json-timedelta-bytes branch August 29, 2023 15:59
@davidhewitt davidhewitt added the relnotes-fix Used for bugfixes. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ser_json_timedelta doesn't apply on JSON schema
4 participants