Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base64Url types #7286

Merged
merged 1 commit into from Aug 29, 2023
Merged

Add Base64Url types #7286

merged 1 commit into from Aug 29, 2023

Conversation

dmontagu
Copy link
Contributor

The lack of these led to some confusion when talking with @Kludex about ser_json_bytes. Seemed easy enough to just add them.

@samuelcolvin and I discussed at some point possibly adding support for serializing json bytes as vanilla (non-URL-safe) base64 in pydantic core, but I think that's unnecessary for now (pydantic core will always serialize as url-safe base64 when that config setting is equal to 'base64').

@dmontagu dmontagu requested a review from Kludex August 29, 2023 14:52
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4df1f2
Status: ✅  Deploy successful!
Preview URL: https://411e013e.pydantic-docs2.pages.dev
Branch Preview URL: https://dmontagu-base64url-types.pydantic-docs2.pages.dev

View logs

@dmontagu dmontagu enabled auto-merge (squash) August 29, 2023 14:55
@dmontagu dmontagu merged commit 84282ef into main Aug 29, 2023
49 checks passed
@dmontagu dmontagu deleted the dmontagu/base64url-types branch August 29, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants