Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix link to model_dump #7297

Merged
merged 1 commit into from Aug 30, 2023
Merged

Docs: fix link to model_dump #7297

merged 1 commit into from Aug 30, 2023

Conversation

acdha
Copy link
Contributor

@acdha acdha commented Aug 30, 2023 •
edited

Change Summary

I noticed that the documentation for model_dump_json() has a link to model_dump() but it was missing an underscore.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@hramezani hramezani merged commit c987bc6 into pydantic:main Aug 30, 2023
49 checks passed
@hramezani
Copy link
Member

Thanks @acdha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acdha @hramezani @davidhewitt