Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override model_post_init in subclass with private attrs #7302

Merged
merged 9 commits into from Sep 11, 2023
Merged

Do not override model_post_init in subclass with private attrs #7302

merged 9 commits into from Sep 11, 2023

Commits on Aug 31, 2023

  1. Do not override model_post_init in subclass with private attrs

    @Viicos
    Viicos committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    9c3c398 View commit details
    Browse the repository at this point in the history

  2. Remove unused comment

    @Viicos
    Viicos committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    39e2c60 View commit details
    Browse the repository at this point in the history

  3. Use a default return value for getattr

    @Viicos
    Viicos committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    031eda6 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Use MRO to determine correct method

    @Viicos
    Viicos committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d6f90ea View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @Viicos
    Viicos committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a8fc2b0 View commit details
    Browse the repository at this point in the history

  3. Try with base.__dict__

    @Viicos
    Viicos committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ecef4e0 View commit details
    Browse the repository at this point in the history

  4. Fix indentation

    @Viicos
    Viicos committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6181f80 View commit details
    Browse the repository at this point in the history

  5. Fix test

    @Viicos
    Viicos committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d5095a9 View commit details
    Browse the repository at this point in the history

  6. Fix bug with get_attribute_from_bases, and use it

    @dmontagu
    dmontagu committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a0591c0 View commit details
    Browse the repository at this point in the history