New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Make EncodedStr
a dataclass
#7396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
please review |
hramezani
reviewed
Sep 12, 2023
pydantic/types.py
Outdated
@@ -1517,6 +1517,7 @@ def __hash__(self) -> int: | |||
return hash(self.encoder) | |||
|
|||
|
|||
@_dataclasses.dataclass() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we make it a slots
dataclass like EncodeBytes
?
Suggested change
@_dataclasses.dataclass() | |
@_dataclasses.dataclass(**_internal_dataclass.slots_true) |
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
adriangb
approved these changes
Sep 20, 2023
The pipeline is going to fail. |
davidhewitt
added
the
relnotes-change
Used for changes to existing functionality which don't have a better categorization.
label
Sep 21, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready for review
relnotes-change
Used for changes to existing functionality which don't have a better categorization.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected Reviewer: @davidhewitt