Standardize __get_pydantic_core_schema__ signature
#7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
e2ad3ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://03b78962.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-get-pydantic-core-schema.pydantic-docs2.pages.dev |
hramezani
force-pushed
the
fix-get-pydantic-core-schema-signature
branch
from
6746688
to
e2ad3ed
Compare
|
please review |
Kludex
changed the title
__get_pydantic_core_schema__ signature__get_pydantic_core_schema__ signature
Kludex
reviewed
Sep 12, 2023
| @@ -360,6 +363,7 @@ def __get_pydantic_json_schema__( | |||
| def __get_pydantic_core_schema__( | |||
| cls, | |||
| source: type[Any], | |||
| handler: _annotated_handlers.GetCoreSchemaHandler, | |||
There was a problem hiding this comment.
Are those needed in this file?
There was a problem hiding this comment.
Actually, not needed because they are working without them. This is just to make all the __get_pydantic_core_schema__ signature similar.
There was a problem hiding this comment.
I see why you changed the other files, but since this is optional here, I would leave without it.
Anyway, not a blocker. Do as you think is more appropriate. 🙏
Kludex
approved these changes
Sep 12, 2023
| @@ -360,6 +363,7 @@ def __get_pydantic_json_schema__( | |||
| def __get_pydantic_core_schema__( | |||
| cls, | |||
| source: type[Any], | |||
| handler: _annotated_handlers.GetCoreSchemaHandler, | |||
There was a problem hiding this comment.
I see why you changed the other files, but since this is optional here, I would leave without it.
Anyway, not a blocker. Do as you think is more appropriate. 🙏
adriangb
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7407
Selected Reviewer: @Kludex