Fix Generic Dataclass Fields Mutation Bug (when using TypeAdapter) #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
aa1d4c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3e55a1f6.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dataclass-fields-mutation-bu.pydantic-docs2.pages.dev |
sydney-runkle
commented
Sep 13, 2023
pydantic/_internal/_core_utils.py
Outdated
| @@ -65,7 +65,7 @@ def get_type_ref(type_: type[Any], args_override: tuple[type[Any], ...] | None = | |||
| when creating generic models without needing to create a concrete class. | |||
| """ | |||
| origin = type_ | |||
| args = args_override or () | |||
| args = type_.__args__ if isinstance(type_, _GenericAlias) else (args_override or ()) # type: ignore | |||
There was a problem hiding this comment.
@dmontagu, could you please explain why we changed this line?
I understand the value of the deepcopy on the model's fields in _generate_schema.py, but I don't quite understand the purpose of this line here.
There was a problem hiding this comment.
I just noticed this misbehavior — right now, it's not producing a type ref that reflects the generic parameters like it is supposed to. In particular, this means that in principle you could get two different schemas with the same ref but that should have different parameters. I don't know why that doesn't seem to be affecting the validation behavior, but I do think this is an improvement either way.
dmontagu
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
fix #7430
Checklist