-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JsonType to config #7475
Added JsonType to config #7475
Conversation
fec2a72
to
2595254
Compare
please review |
please update |
@hramezani of course. I updated all |
please review |
6e4ba54
to
92d3712
Compare
@vladNed I've pushed a commit and fixed the type |
@hramezani looks good, still feels that doesn't approach the first suggested type in the story, as that was a recursive type. But.. if you find this will suite I feel that is more explicit this way. |
If we do this, (which I'm not sure is worthwhile):
Something like: JsonValue: TypeAlias = Union[None, bool, int, float, str, List[JsonValue], Dict[str, JsonValue]]' Please update. |
@sydney-runkle can this be closed since it was replaced by #7803? |
Change Summary
Added
JsonType
to be used forjson_schema_extra
property onConfigDict
Related issue number
Closes #6348
Checklist
Selected Reviewer: @sydney-runkle