Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implement optional number to str coercion #7508

Merged
merged 4 commits into from Sep 21, 2023

Conversation

lig
Copy link
Contributor

@lig lig commented Sep 19, 2023

Change Summary

Implement optional number to str coercion

Related issue number

Fix #6045
Requires pydantic/pydantic-core#975

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 66f34b1
Status: ✅  Deploy successful!
Preview URL: https://6e16cfe7.pydantic-docs2.pages.dev
Branch Preview URL: https://lig-6045-v2-validating-int-s.pydantic-docs2.pages.dev

View logs

@lig lig force-pushed the lig/6045-v2-validating-int-str branch from 664da53 to 2b12488 Compare September 20, 2023 14:15
@lig lig marked this pull request as ready for review September 20, 2023 14:30
@lig
Copy link
Contributor Author

lig commented Sep 20, 2023

please review

Co-authored-by: sydney-runkle <54324534+sydney-runkle@users.noreply.github.com>
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adriangb adriangb merged commit e5323ff into main Sep 21, 2023
50 checks passed
@adriangb adriangb deleted the lig/6045-v2-validating-int-str branch September 21, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 - Validating int->str
4 participants