Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caches for collecting definitions and invalid schemas from a CoreSchema #7527

Merged
merged 2 commits into from Sep 20, 2023
Merged

Add caches for collecting definitions and invalid schemas from a CoreSchema #7527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b2977
Add caches for collecting definitions and invalid schemas from a Core…
adriangb Sep 20, 2023
f0487f6
Revert change to collect_invalid_schemas
adriangb Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions pydantic/_internal/_core_utils.py
View file
Open in desktop
Expand Up @@ -116,6 +116,12 @@ def collect_definitions(schema: core_schema.CoreSchema) -> dict[str, core_schema
defs: dict[str, CoreSchema] = {}

def _record_valid_refs(s: core_schema.CoreSchema, recurse: Recurse) -> core_schema.CoreSchema:
if 'metadata' in s:
definitions_cache: _DefinitionsState | None = s['metadata'].get(_DEFINITIONS_CACHE_METADATA_KEY, None)
if definitions_cache is not None:
defs.update(definitions_cache['definitions'])
return s

ref = get_ref(s)
if ref:
defs[ref] = s
Expand Down