Replace dict.get and dict.setdefault with more verbose versions in CoreSchema building hot paths #7536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
Deploying with
|
| Latest commit: |
72e50b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79fdbc3a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://optimize-schema-building-dic.pydantic-docs2.pages.dev |
hramezani
approved these changes
Sep 21, 2023
This was referenced Sep 22, 2023
|
@adriangb would you be able to include those benchmarks please? I am curious what was the difference in both approaches |
|
Very minor. Mainly creating a new empty dict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've benchmarked this to be slightly faster. Some of these, especially the ones during walking of core schemas, get hit a lot.
Selected Reviewer: @Kludex