Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydantic-core to 2.10.0 #7550

Closed
wants to merge 6 commits into from
Closed

Update pydantic-core to 2.10.0 #7550

wants to merge 6 commits into from

Conversation

adriangb
Copy link
Member

(waiting for release)

@adriangb
Copy link
Member Author

adriangb commented Sep 21, 2023

For what it's worth if I comment out the validate_core_schema calls only 1 test fails that was explicitly testing for this. This tells me that pydantic generally builds valid well typed schemas, so adding an env var based flag to disable schema validation so users can speed up their tests / deployments (e.g. by having only a single test that explicitly validates the schemas by setting the env var to validate and booting up their FastAPI app) would work great. It cuts schema generation time in around half, to better than v1 levels.

@davidhewitt davidhewitt added the relnotes-packaging Used for dependency changes. label Sep 21, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: eb6d9f6
Status: ✅  Deploy successful!
Preview URL: https://2ddc9a3a.pydantic-docs2.pages.dev
Branch Preview URL: https://update-core.pydantic-docs2.pages.dev

View logs

@adriangb
Copy link
Member Author

Looks like we'll need to update FastAPI as well cc @tiangolo

@samuelcolvin
Copy link
Member

replaced by #7542 which cherry-picks some of these commits.

@samuelcolvin samuelcolvin deleted the update-core branch November 14, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-packaging Used for dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants